Made changes #9950
Made changes #9950
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.right = None | ||
|
|
||
| class BinaryTree: | ||
| def __init__(self, root=None) -> None: |
There was a problem hiding this comment.
Please provide type hint for the parameter: root
| def __init__(self, root=None) -> None: | ||
| self.root = root | ||
|
|
||
| def __iter__(self) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function __iter__
| if self.root is not None: | ||
| yield from self._traverse_inorder(self.root) | ||
|
|
||
| def __str__(self) -> str: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function __str__
| def __str__(self) -> str: | ||
| return " ".join(str(data) for data in self) | ||
|
|
||
| def _traverse_inorder(self, node: Node) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function _traverse_inorder
| yield node.data | ||
| yield from self._traverse_inorder(node.right) | ||
|
|
||
| def build_a_tree(self) -> Node: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function build_a_tree
| self.root.right.right.left = Node(35) | ||
| return self.root | ||
|
|
||
| def transform_tree_util(root: Node | None) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function transform_tree_util
| # Recur for left subtree | ||
| transform_tree_util(root.left) | ||
|
|
||
| def binary_tree_to_sum_tree(root: Node | None) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/transform_bst_sum_tree.py, please provide doctest for the function binary_tree_to_sum_tree
for more information, see https://pre-commit.ci
Describe your change:
Fixes #9777
Checklist: